From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Craig Ringer <craig(at)postnewspapers(dot)com(dot)au>, Elliot Chance <elliotchance(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
Date: | 2010-12-27 18:00:34 |
Message-ID: | AANLkTi=TRqqY3xffyCApQwR4P0v71kjchaUDxaK-SCCD@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general pgsql-hackers |
On Mon, Dec 27, 2010 at 18:50, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Excerpts from Tom Lane's message of lun dic 27 13:54:56 -0300 2010:
>>> [ lightbulb ] ... although we could improve that quite a bit if we
>>> processed each .h file separately instead of insisting on smashing
>>> everything into one compilation. Let me go try that.
>
>> FWIW I have this patch lingering about that I wrote months ago, to check
>> for header problems (not C++ stuff, just things like forgetting to
>> include some necessary header in some other header). Since it needs a
>> lot of polish (needs to ignore certain headers, and avoid leave
>> lingering files around), I didn't commit it; and I haven't updated it to
>> the new Make recursive stuff, either.
>
> src/tools/pginclude/ already contains several scripts for this sort of
> thing. Bruce runs them by hand occasionally, although I just found out
> that he's evidently not run the does-each-header-compile-standalone
> test in awhile. It would probably pay to automate these.
Could this at some point be platform dependent? If so, could it be run
on the buildfarm?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-12-27 18:07:03 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
Previous Message | Rob Sargent | 2010-12-27 17:59:47 | Re: 2 versions of an entity worth distinct table? |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-12-27 18:07:03 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
Previous Message | Peter Eisentraut | 2010-12-27 17:50:45 | Re: C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |