| From: | Jacob Champion <pchampion(at)vmware(dot)com> |
|---|---|
| To: | "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "peter(dot)eisentraut(at)enterprisedb(dot)com" <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz> |
| Subject: | Re: Preventing abort() and exit() calls in libpq |
| Date: | 2021-06-30 22:58:22 |
| Message-ID: | 9e32c5120efa37cca606351e4516052107c821bf.camel@vmware.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 2021-06-30 at 18:56 -0400, Tom Lane wrote:
> Jacob Champion <pchampion(at)vmware(dot)com> writes:
> > On Wed, 2021-06-30 at 18:29 -0400, Tom Lane wrote:
> > > Looks like we'd have to make use of a dummy stamp-file, more or less
> > > as attached. Any objections?
> > Spitballing -- if you don't like the stamp file, you could add the
> > check to the end of the $(shlib) rule, surrounded by an ifeq check.
> > Then .DELETE_ON_ERROR should take care of the rest, I think.
>
> Hmm ... I'd been thinking we don't use .DELETE_ON_ERROR, but on
> second look we do, so that could be a plausible approach.
>
> On balance though, the separate rule seems better, because
> .DELETE_ON_ERROR would destroy the evidence about why "nm"
> failed, which could be annoying when investigating problems.
Good point. +1 to the stamp approach, then.
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-06-30 23:00:31 | Re: Dependency to logging in jsonapi.c |
| Previous Message | Tom Lane | 2021-06-30 22:56:56 | Re: Preventing abort() and exit() calls in libpq |