Re: Dependency to logging in jsonapi.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Jacob Champion <pchampion(at)vmware(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Dependency to logging in jsonapi.c
Date: 2021-06-30 23:00:31
Message-ID: 632491.1625094031@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Jun 30, 2021 at 03:47:19PM +0000, Jacob Champion wrote:
>> But until/unless that is changed, an #ifndef seems like a good way to
>> prevent issues for the current code.

> Sounds sensible to do that as well for 14 before the release. Any
> thoughts about that?

If this code were new in v14, I'd be +1, but it looks like it was
there in 13 too. So maybe there's somebody external depending on
it, which would make it a bit unfriendly to remove it post-beta.
Let's just add the #ifndef in HEAD.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-06-30 23:09:28 Re: Small clean up in nodeAgg.c
Previous Message Jacob Champion 2021-06-30 22:58:22 Re: Preventing abort() and exit() calls in libpq