| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add function to import operating system collations |
| Date: | 2017-01-18 17:23:24 |
| Message-ID: | 9b99c8c5-5a77-f1ae-6d90-bef0e85552a0@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 1/18/17 10:43 AM, Tom Lane wrote:
> Maybe an appropriate fix would be to ignore collations whose names aren't
> equal to what we get for collcollate/collctype. Presumably the latter
> are getting canonicalized somehow.
Yeah, it's supposed to do that. Note that the second call to
CollationCreate() in pg_import_system_collations() has the "if not
exists" argument true regardless. So the error appears to come from the
first one.
What's fishy about this is that I can't reproduce it locally in a
variety of VMs, and the buildfarm is not unanimous either.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-01-18 17:26:40 | Re: pgsql: Add function to import operating system collations |
| Previous Message | Euler Taveira | 2017-01-18 17:16:48 | Re: pgsql: Add function to import operating system collations |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-01-18 17:26:40 | Re: pgsql: Add function to import operating system collations |
| Previous Message | Euler Taveira | 2017-01-18 17:16:48 | Re: pgsql: Add function to import operating system collations |