Re: pgsql: Add function to import operating system collations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add function to import operating system collations
Date: 2017-01-18 15:43:07
Message-ID: 2083.1484754187@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

I wrote:
> running bootstrap script ... ok
> performing post-bootstrap initialization ... 2017-01-18 09:49:45.019 EST [25919] FATAL: collation "aa_ER(at)saaho" for encoding "UTF8" already exists
> 2017-01-18 09:49:45.019 EST [25919] STATEMENT: SELECT pg_import_system_collations(if_not_exists => false, schema => 'pg_catalog');

As a stopgap so I could get some work done, I did

- PG_CMD_PUTS("SELECT pg_import_system_collations(if_not_exists => false, schema => 'pg_catalog');\n\n");
+ PG_CMD_PUTS("SELECT pg_import_system_collations(if_not_exists => true, schema => 'pg_catalog');\n\n");

and what I now see in pg_collation is

regression=# select * from pg_collation where collname like 'aa_ER%';
collname | collnamespace | collowner | collencoding | collcollate | collctype
------------------+---------------+-----------+--------------+------------------+------------------
aa_ER | 11 | 10 | 6 | aa_ER | aa_ER
aa_ER.utf8 | 11 | 10 | 6 | aa_ER.utf8 | aa_ER.utf8
aa_ER(dot)utf8(at)saaho | 11 | 10 | 6 | aa_ER(dot)utf8(at)saaho | aa_ER(dot)utf8(at)saaho
aa_ER(at)saaho | 11 | 10 | 6 | aa_ER(dot)utf8(at)saaho | aa_ER(dot)utf8(at)saaho
(4 rows)

Maybe an appropriate fix would be to ignore collations whose names aren't
equal to what we get for collcollate/collctype. Presumably the latter
are getting canonicalized somehow.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Euler Taveira 2017-01-18 17:16:48 Re: pgsql: Add function to import operating system collations
Previous Message Tom Lane 2017-01-18 14:53:16 Re: pgsql: Add function to import operating system collations

Browse pgsql-hackers by date

  From Date Subject
Next Message Jesper Pedersen 2017-01-18 15:45:03 Re: pageinspect: Hash index support
Previous Message Vladimir Rusinov 2017-01-18 15:09:32 Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal