Re: DBT-3 with SF=20 got failed

From: Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: DBT-3 with SF=20 got failed
Date: 2015-09-08 12:28:18
Message-ID: 9A28C8860F777E439AA12E8AEA7694F8011403FD@BPXM15GP.gisp.nec.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Hello KaiGai-san,
>
> I've discovered a bug in the proposed patch - when resetting the hash
> table after the first batch, it does this:
>
> memset(hashtable->buckets, 0, sizeof(nbuckets * sizeof(HashJoinTuple)));
>
> The first 'sizeof' is bogus, so this only zeroes the first 8 bytes of
> the array (usually resulting in crashes due to invalid pointers).
>
> I fixed it to
>
> memset(hashtable->buckets, 0, nbuckets * sizeof(HashJoinTuple));
>
> Fixed patch attached (marked as v2).
>
Thanks, it was my bug, but oversight.

I want committer to push this fix.
--
NEC Business Creation Division / PG-Strom Project
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2015-09-08 12:49:44 Re: Small patch to fix an O(N^2) problem in foreign keys
Previous Message Robert Haas 2015-09-08 12:06:23 Re: proposal: function parse_ident