Re: [v9.5] Custom Plan API

From: Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, "Kohei KaiGai" <kaigai(at)kaigai(dot)gr(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)2ndquadrant(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org>, Jim Mlodgenski <jimmy76(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Subject: Re: [v9.5] Custom Plan API
Date: 2014-12-06 23:21:58
Message-ID: 9A28C8860F777E439AA12E8AEA7694F80108DB68@BPXM15GP.gisp.nec.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Simon,

> > Yes please. We have other contrib modules that exist as tests, so this
> > seems reasonable to me.
>
> I can't improve the docs without the example code. Is that available now?
>
Please wait for a few days. The ctidscan module is not adjusted for the
latest interface yet.

--
NEC OSS Promotion Center / PG-Strom Project
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>

> -----Original Message-----
> From: Simon Riggs [mailto:simon(at)2ndQuadrant(dot)com]
> Sent: Sunday, December 07, 2014 12:37 AM
> To: Kaigai Kouhei(海外 浩平)
> Cc: Robert Haas; Thom Brown; Kohei KaiGai; Tom Lane; Alvaro Herrera; Shigeru
> Hanada; Stephen Frost; Andres Freund; PgHacker; Jim Mlodgenski; Peter
> Eisentraut
> Subject: Re: [HACKERS] [v9.5] Custom Plan API
>
> On 27 November 2014 at 20:48, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> > On 27 November 2014 at 10:33, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> wrote:
> >
> >> The reason why documentation portion was not yet committed is, sorry,
> >> it is due to quality of documentation from the standpoint of native
> >> English speaker.
> >> Now, I'm writing up a documentation stuff according to the latest
> >> code base, please wait for several days and help to improve.
> >
> > Happy to help with that.
> >
> > Please post to the Wiki first so we can edit it communally.
>
> I've corrected a spelling mistake, but it reads OK at moment.
>
>
> >>> The example contrib module was not committed and I am advised no
> >>> longer works.
> >>>
> >> May I submit the contrib/ctidscan module again for an example?
> >
> > Yes please. We have other contrib modules that exist as tests, so this
> > seems reasonable to me.
>
> I can't improve the docs without the example code. Is that available now?
>
> --
> Simon Riggs http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2014-12-07 01:54:14 PATCH: adaptive ndistinct estimator v3 (WAS: Re: [PERFORM] Yet another abort-early plan disaster on 9.3)
Previous Message Tomas Vondra 2014-12-06 21:59:00 Re: excessive amounts of consumed memory (RSS), triggering OOM killer