| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix runtime errors from -fsanitize=undefined |
| Date: | 2019-07-05 16:14:31 |
| Message-ID: | 98a37944-6880-1c61-4aea-21fd0ba0b3bb@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-07-05 01:33, Noah Misch wrote:
> I just saw this proposal. The undefined behavior in question is strictly
> academic. These changes do remove the need for new users to discover
> -fno-sanitize=nonnull-attribute, but they make the code longer and no clearer.
> Given the variety of code this touches, I expect future commits will
> reintroduce the complained-of usage patterns, prompting yet more commits to
> restore the invariant achieved here. Hence, I'm -0 for this change.
This sanitizer has found real problems in the past. By removing these
trivial issues we can then set up a build farm animal or similar to
automatically check for any new issues.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-07-05 16:16:03 | Re: Add parallelism and glibc dependent only options to reindexdb |
| Previous Message | Tomas Vondra | 2019-07-05 16:04:56 | Re: mcvstats serialization code is still shy of a load |