| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adding argument names to aggregate functions |
| Date: | 2023-07-19 19:38:12 |
| Message-ID: | 98834F2E-B4E3-4084-8D81-4B3DD8D666E0@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 19 Jul 2023, at 19:32, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> wrote:
>
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>
>> This patch no longer applied but had a fairly trivial conflict so I've attached
>> a rebased v3 addressing the conflict in the hopes of getting this further.
>
> Thanks for the heads-up! Turns out the conflict was due to the new
> json(b)_object_agg(_unique)(_strict) functions, which should also have
> proargnames added. Here's an updated patch that does that.
Great, thanks! I had a quick look at this while rebasing (as well as your
updated patch) and it seems like a good idea to add this. Unless there are
objections I will look at getting this in.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-07-19 20:26:02 | Re: Giving more detail in pg_upgrade errormessage |
| Previous Message | Andrew Dunstan | 2023-07-19 19:20:22 | Re: Extracting cross-version-upgrade knowledge from buildfarm client |