| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A minor correction in comment in heaptuple.c |
| Date: | 2014-01-25 21:53:39 |
| Message-ID: | 9702.1390686819@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-01-25 16:28:09 -0500, Bruce Momjian wrote:
>> Is everyone OK with me applying this patch from Kevin, attached?
> No. I still think this is stupid. Not at all clearer and possibly breaks
> stuff.
I agree; this patch is flat out wrong. It converts a valid situation
which is correctly handled into an Assert trap, or probably a core dump
in a non-assert build.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-01-25 21:54:12 | Re: A better way than tweaking NTUP_PER_BUCKET |
| Previous Message | Andrew Dunstan | 2014-01-25 21:50:35 | Re: What is happening on buildfarm member crake? |