| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <gsstark(at)mit(dot)edu>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |
| Date: | 2009-08-12 13:35:30 |
| Message-ID: | 9691.1250084130@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Tom Lane escribi:
>> Um, sorry, no reason to do which?
> No reason not to leave prototypes alone in the AWK code. Isn't the
> style emitted by indent good enough already? The comment that ctags
> needs it is probably outdated (I know my ctags, the Exuberant one,
> doesn't).
Personally I quite like the fact that the function definition is the
only place where the function name appears left-justified. Modern ctags
might or might not care, but there are all sorts of code search tools
out there and we should not presume which ones developers are using.
I vote against changing it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2009-08-12 13:38:30 | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |
| Previous Message | Robert Haas | 2009-08-12 13:34:41 | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2009-08-12 13:35:48 | Re: WIP: getting rid of the pg_database flat file |
| Previous Message | Robert Haas | 2009-08-12 13:34:41 | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |