From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Greg Stark <gsstark(at)mit(dot)edu>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |
Date: | 2009-08-12 13:56:37 |
Message-ID: | 603c8f070908120656ne038aabl5aab4ff5cec9933f@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Aug 12, 2009 at 9:35 AM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Tom Lane escribió:
>>> Um, sorry, no reason to do which?
>
>> No reason not to leave prototypes alone in the AWK code. Isn't the
>> style emitted by indent good enough already? The comment that ctags
>> needs it is probably outdated (I know my ctags, the Exuberant one,
>> doesn't).
>
> Personally I quite like the fact that the function definition is the
> only place where the function name appears left-justified. Modern ctags
> might or might not care, but there are all sorts of code search tools
> out there and we should not presume which ones developers are using.
> I vote against changing it.
+1000. I use git grep '^function_name' constantly.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2009-08-12 13:57:15 | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |
Previous Message | Alvaro Herrera | 2009-08-12 13:38:30 | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2009-08-12 13:57:15 | Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY) |
Previous Message | Robert Haas | 2009-08-12 13:55:25 | Re: machine-readable explain output v4 |