Re: Code review in dsa.c

HI,

On Jan 15, 2023, 23:43 +0800, Zhang Mingli <zmlpostgres(at)gmail(dot)com>, wrote:
> Hi, hackers
>
> Found  some functions in dsa.c are not used anymore.
>
> dsa_create
> dsa_attach
> dsa_get_handle
> dsa_trim
> dsa_dump
>
> We once used dsa_create to create DSA and  it ’s all replaced by dsa_create_in_place since commit 31ae1638ce.
> dsa_attach and dsa_get_handle cooperate with dsa_create.
> dsa_trim and dsa_dump are introduced by DSA original commit 13df76a537 , but not used since then.
>
> So, they are all dead codes, provide a patch to remove them.

Patch updated.
Forget to remove dsa_unpin in dsa.h, dsa_unpin is also not used since commit 13df76a537.
The gemel function dsa_pin is only used in pg_stat. Seems reasonable that we don’t need to call dsa_unpin in pg_stat.

Regards,
Zhang Mingli