| From: | Zhang Mingli <zmlpostgres(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Code review in dsa.c |
| Date: | 2023-01-15 15:43:49 |
| Message-ID: | 49bebf7a-059a-4750-ba30-3fe0a734e4e9@Spark |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, hackers
Found some functions in dsa.c are not used anymore.
dsa_create
dsa_attach
dsa_get_handle
dsa_trim
dsa_dump
We once used dsa_create to create DSA and it ’s all replaced by dsa_create_in_place since commit 31ae1638ce.
dsa_attach and dsa_get_handle cooperate with dsa_create.
dsa_trim and dsa_dump are introduced by DSA original commit 13df76a537 , but not used since then.
So, they are all dead codes, provide a patch to remove them.
Regards,
Zhang Mingli
| Attachment | Content-Type | Size |
|---|---|---|
| v0-0001-Remove-unused-functions-in-dsa.c.patch | application/octet-stream | 12.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-01-15 16:01:10 | Re: Extracting cross-version-upgrade knowledge from buildfarm client |
| Previous Message | houzj.fnst@fujitsu.com | 2023-01-15 14:46:42 | RE: logrep stuck with 'ERROR: int2vector has too many elements' |