| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Switch to multi-inserts for pg_depend |
| Date: | 2020-09-03 07:47:07 |
| Message-ID: | 9519B099-7AB6-44A1-9365-B912AE7D2FC6@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 3 Sep 2020, at 07:35, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Sep 01, 2020 at 11:53:36AM +0200, Daniel Gustafsson wrote:
>> On 14 Aug 2020, at 20:23, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>>
>>> The logic to keep track number of used slots used is baroque, though -- that
>>> could use a lot of simplification.
>>
>> What if slot_init was an integer which increments together with the loop
>> variable until max_slots is reached? If so, maybe it should be renamed
>> slot_init_count and slotCount renamed slot_stored_count to make the their use
>> clearer?
>
> Good idea, removing slot_init looks like a good thing for readability.
> And the same can be done for pg_shdepend.
I think this version is a clear improvement. Nothing more sticks out from a
read-through.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-09-03 08:04:40 | Making index_set_state_flags() transactional |
| Previous Message | Peter Smith | 2020-09-03 07:35:36 | Re: extension patch of CREATE OR REPLACE TRIGGER |