Re: several minor cleanups

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: several minor cleanups
Date: 2002-07-16 06:27:49
Message-ID: 9454.1026800869@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> Well, I think the practice of reporting C function names for
>> user-visible error messages isn't a particularly good idea -- but if
>> we'd like to fix that, this is only one of numerous error messages that
>> need to be corrected.

> Is there any desire for this to be done?

I am *strongly* against removing those names until such time as we have
a substitute mechanism for identifying where error messages come from
in the source. We've talked before about making __FILE__/__LINE__ info
available as a secondary field in error messages, as part of a general
overhaul of error reporting ... but no one seems to want to tackle it...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2002-07-16 06:32:18 Re: several minor cleanups
Previous Message Bruce Momjian 2002-07-16 06:07:12 Re: Unique / Primary key constraints