From: | "Dave Page" <dpage(at)pgadmin(dot)org> |
---|---|
To: | "Guillaume Lelarge" <guillaume(at)lelarge(dot)info> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Buglets in dlgFunction |
Date: | 2008-10-18 07:38:04 |
Message-ID: | 937d27e10810180038t2b756e6fqe3f79b54e1f089f6@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Thu, Oct 16, 2008 at 3:38 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Here is a new (complete) patch. I don't like at all what I did but it
> seems to fix your issues.
OK, here we go....
dlgTable:
Existing table: OK
New table: OK
dlgSequence:
Existing sequence: OK
New sequence: OK
dlgDatabase:
New database: OK
Existing database: OK
dlgPackage:
Existing package: OK
New package: OK
dlgTablespace:
New tablespace: OK
Existing tablespace: OK
dlgSchema:
Existing schema: OK
New schema: OK
dlgView:
Existing view: OK
New view: OK
Nice work!! So, let's please get this applied so we can put it to bed.
A couple of minor fixes:
- In dlgFunction::Go @367, you have:
returncode = dlgSecurityProperty::Go(modal);
returncode = dlgSecurityProperty::Go(modal);
Copy/paste error?
- Please add a comment to each instance of the ugly resize blocks to
explain what it's doing so we don't forget in 6 months :-)
Thanks!
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Gevik Babakhani | 2008-10-18 21:43:27 | Re: extending functionality strategy |
Previous Message | Guillaume Lelarge | 2008-10-17 12:05:39 | Re: Buglets in dlgFunction |