From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Buglets in dlgFunction |
Date: | 2008-10-19 21:33:21 |
Message-ID: | 48FBA7A1.4030401@lelarge.info |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Dave Page a écrit :
> [...]
> Nice work!! So, let's please get this applied so we can put it to bed.
> A couple of minor fixes:
>
> - In dlgFunction::Go @367, you have:
>
> returncode = dlgSecurityProperty::Go(modal);
>
> returncode = dlgSecurityProperty::Go(modal);
>
> Copy/paste error?
>
Yes. There was also two return statements.
> - Please add a comment to each instance of the ugly resize blocks to
> explain what it's doing so we don't forget in 6 months :-)
>
Done. Not sure my words are easy to understand. Feel free to change them
to something more appropriate.
Thanks. I still don't like this hack. I hope I'll soon better understand
this issue to replace the ugly code with a good one.
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2008-10-20 08:47:11 | Re: extending functionality strategy |
Previous Message | svn | 2008-10-19 21:30:11 | SVN Commit by guillaume: r7490 - in trunk/pgadmin3/pgadmin: agent ctl dlg include/dlg ui |