From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com> |
Cc: | PgHacker <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: RULE regression test fragility? |
Date: | 2013-10-24 00:50:30 |
Message-ID: | 9374.1382575830@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com> writes:
> While reviewing the Network Stats Traffic patch I discovered the current
> regression test for rules depends on the system view definitions not
> changing:
Yes, this is standard. We just update the expected output anytime
somebody changes a system view.
(Now, if the submitter failed to notice that his patch broke the
regression tests, that's grounds to wonder how much he tested it.
But it's not unexpected for that test's output to change.)
> [ Is it really a good idea for the regression tests to do that? ]
I tend to think so, as it seems like a good stress test for the
rule-dumping machinery.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Gordon Mohr | 2013-10-24 01:50:34 | high-dimensional knn-GIST tests (was Re: Cube extension kNN support) |
Previous Message | Peter Geoghegan | 2013-10-24 00:25:22 | Re: Add min and max execute statement time in pg_stat_statement |