From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com>, PgHacker <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: RULE regression test fragility? |
Date: | 2013-10-24 08:23:25 |
Message-ID: | 20131024082325.GF823737@alap2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2013-10-23 20:50:30 -0400, Tom Lane wrote:
> Mike Blackwell <mike(dot)blackwell(at)rrd(dot)com> writes:
> > While reviewing the Network Stats Traffic patch I discovered the current
> > regression test for rules depends on the system view definitions not
> > changing:
>
> Yes, this is standard. We just update the expected output anytime
> somebody changes a system view.
FWIW, I've repeatedly now thought that it'd make maintaining/updating
patches easier if we switched that query into unaligned tuple only (\a
\t) mode. That would remove the frequent conflicts on the row count and
widespread changes due to changed alignment.
Alternatively we could just wrap the query in \copy ... CSV.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Haribabu kommi | 2013-10-24 08:59:47 | Regress tests to improve the function coverage of schemacmds and user and tablespace files |
Previous Message | Andres Freund | 2013-10-24 08:18:04 | Re: CLUSTER FREEZE |