From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Fix search_path to a safe value during maintenance operations. |
Date: | 2023-07-06 07:55:14 |
Message-ID: | 931c23465c331fc3d53073cdefa53bad464b0469.camel@j-davis.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, 2023-06-29 at 22:09 -0700, Nathan Bossart wrote:
> On Thu, Jun 29, 2023 at 08:53:56PM -0400, Tom Lane wrote:
> > I'm leaning to Robert's thought that we need to revert this for
> > now,
> > and think harder about how to make it work cleanly and safely.
>
> Since it sounds like this is headed towards a revert, here's a patch
> for
> removing MAINTAIN and pg_maintain.
It was difficult to review standalone, so I tried a quick version
myself and ended up with very similar results. The only substantial
difference was that I put back:
+ if (!vacuum_is_relation_owner(relid, classForm,
options))
+ continue;
in get_all_vacuum_rels() whereas your patch left it out -- double-check
that we're doing the right thing there.
Also remember to bump the catversion. Other than that, it looks good to
me.
Regards,
Jeff Davis
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2023-07-06 10:06:51 | pgsql: Fix MarkGUCPrefixReserved() to check all options. |
Previous Message | Amit Kapila | 2023-07-06 06:26:48 | pgsql: Fix code indentation vioaltion introduced in commit cc32ec24fd. |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2023-07-06 07:56:18 | Re: Add estimated hit ratio to Memoize in EXPLAIN to explain cost adjustment |
Previous Message | Masahiko Sawada | 2023-07-06 07:36:13 | Re: RFC: pg_stat_logmsg |