| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix search_path to a safe value during maintenance operations. |
| Date: | 2023-07-06 17:20:04 |
| Message-ID: | 20230706172004.GA3635686@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Jul 06, 2023 at 12:55:14AM -0700, Jeff Davis wrote:
> It was difficult to review standalone, so I tried a quick version
> myself and ended up with very similar results.
Thanks for taking a look.
> The only substantial
> difference was that I put back:
>
>
> + if (!vacuum_is_relation_owner(relid, classForm,
> options))
> + continue;
>
>
> in get_all_vacuum_rels() whereas your patch left it out -- double-check
> that we're doing the right thing there.
The privilege check was moved in d46a979, which I think still makes sense,
so I left it there. That might be why it looks like I removed it.
> Also remember to bump the catversion. Other than that, it looks good to
> me.
Will do.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-07-06 17:29:03 | pgsql: Fix type of iterator variable in SH_START_ITERATE |
| Previous Message | Andrew Dunstan | 2023-07-06 16:37:55 | pgsql: Skip pg_baseback long filename test if path too long on Windows |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-07-06 17:33:24 | Re: Avoid overflow with simplehash |
| Previous Message | Gurjeet Singh | 2023-07-06 17:14:31 | Re: MERGE ... RETURNING |