Re: [PROPOSAL] TAP test example

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
Cc: Nikolay Shaplov <n(dot)shaplov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PROPOSAL] TAP test example
Date: 2015-11-19 16:23:53
Message-ID: 9278.1447950233@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> writes:
> On 11/19/15 9:57 AM, Tom Lane wrote:
>> Agreed. We aren't going to accept any core tests that depend on DBI/DBD.
>> Now, that might be a fine example for tests written to test something that
>> uses Postgres ... but not as an example of how to write a core test.

> Isn't one of the goals of the TAP framework to be able to write SQL
> level tests where we don't have to worry about random output changes,
> like what line number on a script caused an error?

So?

Actually, I would say that one of the most serious black marks against
every one of the TAP tests we've got is the difficulty of finding out why
a test failed, when that happens. "ok" versus "not ok" simply doesn't cut
it. So the idea of not reporting what the actual output was doesn't seem
attractive to me at all.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Shaplov 2015-11-19 16:26:49 Re: [PROPOSAL] TAP test example
Previous Message Alvaro Herrera 2015-11-19 16:18:46 Re: GIN pending list clean up exposure to SQL