Re: GIN pending list clean up exposure to SQL

Alvaro Herrera wrote:
> Jeff Janes wrote:
> > I've written a function which allows users to clean up the pending list.
> > It takes the index name and returns the number of pending list pages
> > deleted.
>
> I just noticed that your patch uses AccessShareLock on the index. Is
> that okay? I would have assumed that you'd need ShareUpdateExclusive
> (same as vacuum uses), but I don't really know. Was that a carefully
> thought-out choice?

After reading gitPendingCleanup it becomes clear that there's no need
for a stronger lock than what you've chosen. Jaime Casanova just
pointed this out to me.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services