Re: pgsql: Add support for basic NUMA awareness

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add support for basic NUMA awareness
Date: 2025-04-16 18:25:01
Message-ID: 91E6AC4C-4541-4E7D-9DFE-4399A172A888@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 16 Apr 2025, at 20:15, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>
> On 4/16/25 18:34, Jacob Champion wrote:
>> On Wed, Apr 16, 2025 at 9:30 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>> It seems like this commit didn't run autoheader, which leaves a trivial diff in
>>> pg_config.h.in carried over for future callers. It doesn't change anuything
>>> really as the HAVE_LIBNUMA macro isn't used, but for completeness sake we
>>> should probably add it?
>>
>> +1, I ran autoreconf during a rebase today and had to undo the new NUMA hunks :D
>>
>> Your patch looks the same as what I'm carrying locally.
>
> Ah, I didn't notice the autoheader thing. The patch looks fine to me.
> Daniel, do you intend to push it, or do you want me to do that?

I was just in the terminal pushing it, thanks for confirming the patch was
good.

--
Daniel Gustafsson

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2025-04-16 20:02:33 pgsql: Elide not-null constraint checks on child tables during PK creat
Previous Message Daniel Gustafsson 2025-04-16 18:22:28 pgsql: Update pg_config.h.in with libnuma changes