| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add support for basic NUMA awareness |
| Date: | 2025-04-16 18:15:13 |
| Message-ID: | 2fa11ead-c923-470e-be29-232509317904@vondra.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 4/16/25 18:34, Jacob Champion wrote:
> On Wed, Apr 16, 2025 at 9:30 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> It seems like this commit didn't run autoheader, which leaves a trivial diff in
>> pg_config.h.in carried over for future callers. It doesn't change anuything
>> really as the HAVE_LIBNUMA macro isn't used, but for completeness sake we
>> should probably add it?
>
> +1, I ran autoreconf during a rebase today and had to undo the new NUMA hunks :D
>
> Your patch looks the same as what I'm carrying locally.
>
Ah, I didn't notice the autoheader thing. The patch looks fine to me.
Daniel, do you intend to push it, or do you want me to do that?
regards
--
Tomas Vondra
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-04-16 18:22:28 | pgsql: Update pg_config.h.in with libnuma changes |
| Previous Message | Álvaro Herrera | 2025-04-16 17:44:21 | Re: pgsql: Non text modes for pg_dumpall, correspondingly change pg_restore |