Re: Rename setup_cancel_handler in pg_dump

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Rename setup_cancel_handler in pg_dump
Date: 2024-02-07 21:59:48
Message-ID: 90F494D5-9CB4-4E23-AAA1-FBDBA5F749B8@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 1 Feb 2024, at 02:21, Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
> On Tue, 30 Jan 2024 13:44:28 +0100
> Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

>> -setup_cancel_handler(void)
>> +pg_dump_setup_cancel_handler(void)
>>
>> We don't have any other functions prefixed with pg_dump_, based on the naming
>> of the surrounding code in the file I wonder if set_cancel_handler is a more
>> appropriate name?
>
> Agreed. Here is a updated patch.

Sleeping on it I still think this is a good idea, and hearing no objections I
went ahead with this. Thanks for the patch!

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message James Coleman 2024-02-07 22:03:43 Re: Question about behavior of deletes with REPLICA IDENTITY NOTHING
Previous Message Andres Freund 2024-02-07 21:48:57 Re: glibc qsort() vulnerability