Re: Rename setup_cancel_handler in pg_dump

On Wed, 7 Feb 2024 22:59:48 +0100
Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

> > On 1 Feb 2024, at 02:21, Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> wrote:
> > On Tue, 30 Jan 2024 13:44:28 +0100
> > Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> >> -setup_cancel_handler(void)
> >> +pg_dump_setup_cancel_handler(void)
> >>
> >> We don't have any other functions prefixed with pg_dump_, based on the naming
> >> of the surrounding code in the file I wonder if set_cancel_handler is a more
> >> appropriate name?
> >
> > Agreed. Here is a updated patch.
>
> Sleeping on it I still think this is a good idea, and hearing no objections I
> went ahead with this. Thanks for the patch!

Thank you!

Regards,
Yugo Nagata

>
> --
> Daniel Gustafsson
>

--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>