Re: PATCH: add "--config-file=" option to pg_rewind

From: "Gunnar \"Nick\" Bluth" <gunnar(dot)bluth(at)pro-open(dot)de>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, Alexander Kukushkin <cyberdemn(at)gmail(dot)com>
Cc: Aleksander Alekseev <aleksander(at)timescale(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: PATCH: add "--config-file=" option to pg_rewind
Date: 2022-02-24 13:43:17
Message-ID: 90730332-8d6e-eeaf-b8f3-d5c7a440ff0a@pro-open.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Am 24.02.2022 um 14:08 schrieb Daniel Gustafsson:
>> On 24 Feb 2022, at 10:27, Alexander Kukushkin <cyberdemn(at)gmail(dot)com> wrote:
>>
>> Hello Gunnar,
>>
>> On Thu, 24 Feb 2022 at 10:03, Aleksander Alekseev <aleksander(at)timescale(dot)com> wrote:
>>
>>> wants to use the "-c" option on a typical Debian/Ubuntu installation
>>> (where the config resides below /etc/postgresql/), pg_rewind needs a way
>>> to be told where the postgresql.conf actually is.
>>>
>>> The attached patch implements this as an option.
>>>
>>> [...]
>>
>> Good catch!
>>
>> Yeah, it is a known problem, and there was already another patch trying to address it [1].
>
> There is yet another related patch which provides a parameter to pass in
> restore_command in cases where postgresq.conf isn't reachable:
>
> https://commitfest.postgresql.org/37/3213/

That looks just as good to me, and it already has tests, so I'll happily
step down!

(Note to myself: check the CF first next time ;-)
--
Gunnar "Nick" Bluth

Eimermacherweg 106
D-48159 Münster

Mobil +49 172 8853339
Email: gunnar(dot)bluth(at)pro-open(dot)de
__________________________________________________________________________
"Ceterum censeo SystemD esse delendam" - Cato

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-02-24 13:44:05 Re: Typo in pgbench messages.
Previous Message Daniel Gustafsson 2022-02-24 13:20:02 Re: Readd use of TAP subtests