Re: Typo in pgbench messages.

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, kawamoto(at)sraoss(dot)co(dot)jp, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Typo in pgbench messages.
Date: 2022-02-24 13:44:05
Message-ID: 5701D080-4E53-4DEC-AF1C-BADB54ACCE4D@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 24 Feb 2022, at 13:58, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:

>> One argument against a backpatch is that this would be disruptive with
>> tools that parse and analyze the output generated by pgbench. Fabien,
>> don't you have some tools and/or wrappers doing exactly that?
>
> Yep, I like to "| cut -d' ' -fx" and other "line.split(' ')" or whatever.
>
> I think that the break of typographical rules is intentional to allow such simplistic low-level stream handling through pipes or scripts. I'd prefer that the format is not changed. Maybe a comment could be added to explain the reason behind it.

That doesn't sound like an overwhelmingly convincing argument to print some
messages with 'X %' and others with 'X%'.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-02-24 13:46:49 Re: PATCH: add "--config-file=" option to pg_rewind
Previous Message Gunnar "Nick" Bluth 2022-02-24 13:43:17 Re: PATCH: add "--config-file=" option to pg_rewind