Re: stored procedure stats in collector

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com>
Cc: Volkan YAZICI <yazicivo(at)ttmail(dot)com>, pgsql-patches(at)postgresql(dot)org, postgres(at)cybertec(dot)at
Subject: Re: stored procedure stats in collector
Date: 2008-05-14 00:43:19
Message-ID: 9048.1210725799@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Martin Pihlak <martin(dot)pihlak(at)gmail(dot)com> writes:
> Now I just realized that the current patch doesn't handle this quite
> correctly. Modified patch attached.

I'm starting to look through this now, and I notice that the various
code paths in execQual.c are not too consistent about whether it counts
as a call if a strict function is skipped over because of NULL
arguments. I'm inclined to make it uniformly say that that's not a call
and is not included in the stats --- any objections?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-05-14 01:55:53 Re: Syntax decisions for pl/pgsql RAISE extension
Previous Message Decibel! 2008-05-14 00:20:27 Re: Syntax decisions for pl/pgsql RAISE extension

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-05-14 00:43:28 Re: Making sure \timing is on
Previous Message Tom Lane 2008-05-13 23:11:01 Re: Making sure \timing is on