| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| Date: | 2021-10-14 21:13:35 |
| Message-ID: | 903680.1634246015@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> writes:
> The pg_amcheck patch Peter committed for me adds a new test, src/bin/pg_amcheck/t/006_bad_targets.pl, which creates two PostgresNode objects (a primary and a standby) and uses PostgresNode::background_psql(). It doesn't bother to "finish" the returned harness, which may be the cause of an installation hanging around long enough to be in the way when another test tries to start.
(a) Isn't that just holding open one connection, not the whole instance?
(b) Wouldn't finish()ing that connection cause the temp tables to be
dropped, negating the entire point of the test?
TBH, I seriously doubt this test case is worth expending buildfarm
cycles on forevermore. I'm more than a bit tempted to just drop
it, rather than also expending developer time figuring out why it's
not as portable as it looks.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2021-10-14 21:18:01 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| Previous Message | Tom Lane | 2021-10-14 21:09:23 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2021-10-14 21:16:15 | Re: [RFC] building postgres with meson |
| Previous Message | Tom Lane | 2021-10-14 21:09:23 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |