| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| Date: | 2021-10-14 21:18:01 |
| Message-ID: | 2306C399-4919-4694-9A0E-72CB5EE1D0B8@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
> On Oct 14, 2021, at 2:13 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> (a) Isn't that just holding open one connection, not the whole instance?
Yes.
> (b) Wouldn't finish()ing that connection cause the temp tables to be
> dropped, negating the entire point of the test?
The finish() would have to be the last line of the test.
> TBH, I seriously doubt this test case is worth expending buildfarm
> cycles on forevermore. I'm more than a bit tempted to just drop
> it, rather than also expending developer time figuring out why it's
> not as portable as it looks.
I'm curious if the test is indicating something about the underlying test system. Only one other test in the tree uses background_psql(). I was hoping Andrew would have something to say about whether this is a bug with that function or just user error on my part.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-10-14 21:21:47 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| Previous Message | Tom Lane | 2021-10-14 21:13:35 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-10-14 21:21:47 | Re: BUG #17212: pg_amcheck fails on checking temporary relations |
| Previous Message | John Naylor | 2021-10-14 21:16:15 | Re: [RFC] building postgres with meson |