| From: | Sofia Kopikova <s(dot)kopikova(at)postgrespro(dot)ru> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Apply PGDLLIMPORT markings to some GUC variables |
| Date: | 2024-08-14 10:14:48 |
| Message-ID: | 8ff5dbce-9eb2-4a22-b1dd-d6d387a5838c@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/14/24 12:50, Peter Eisentraut wrote:
> On 13.08.24 21:00, Robert Haas wrote:
>> On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
>> <s(dot)kopikova(at)postgrespro(dot)ru> wrote:
>>> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
>>> header files. According to the commit message in 8ec569479, all
>>> variables in header files must be marked with PGDLLIMPORT, am I right?
>>>
>>> I've made a patch that adds missing PGDLLIMPORTs, please, take a look.
>>
>> This seems correct to me.
>
> committed
>
Many thanks for quick review and commit.
--
Best regards,
Sofia Kopikova
Postgres Professional: http://www.postgrespro.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2024-08-14 11:01:22 | [PATCH] Add get_bytes() and set_bytes() functions |
| Previous Message | Peter Eisentraut | 2024-08-14 09:50:08 | Re: Apply PGDLLIMPORT markings to some GUC variables |