Re: Apply PGDLLIMPORT markings to some GUC variables

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Sofia Kopikova <s(dot)kopikova(at)postgrespro(dot)ru>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Apply PGDLLIMPORT markings to some GUC variables
Date: 2024-08-14 09:50:08
Message-ID: 859061b6-8aa6-49dc-be88-bdf7eebcbbb3@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 13.08.24 21:00, Robert Haas wrote:
> On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
> <s(dot)kopikova(at)postgrespro(dot)ru> wrote:
>> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
>> header files. According to the commit message in 8ec569479, all
>> variables in header files must be marked with PGDLLIMPORT, am I right?
>>
>> I've made a patch that adds missing PGDLLIMPORTs, please, take a look.
>
> This seems correct to me.

committed

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sofia Kopikova 2024-08-14 10:14:48 Re: Apply PGDLLIMPORT markings to some GUC variables
Previous Message shveta malik 2024-08-14 09:23:25 Re: [bug fix] prepared transaction might be lost when max_prepared_transactions is zero on the subscriber