| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Relation bulk write facility |
| Date: | 2024-02-23 15:43:28 |
| Message-ID: | 8a5a2f85-9a75-4d2d-9c75-0608ee98886b@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23/02/2024 17:15, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> Buildfarm animals 'sifaka' and 'longfin' are not happy, I will investigate..
>
> Those are mine, let me know if you need local investigation.
Thanks, the error message was clear enough:
> bulk_write.c:78:3: error: redefinition of typedef 'BulkWriteState' is a C11 feature [-Werror,-Wtypedef-redefinition]
> } BulkWriteState;
> ^
> ../../../../src/include/storage/bulk_write.h:20:31: note: previous definition is here
> typedef struct BulkWriteState BulkWriteState;
> ^
> 1 error generated.
Fixed now, but I'm a bit surprised other buildfarm members nor cirrus CI
caught that. I also tried to reproduce it locally by adding
-Wtypedef-redefinition, but my version of clang didn't produce any
warnings. Are there any extra compiler options on those animals or
something?
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-02-23 16:06:01 | Re: Relation bulk write facility |
| Previous Message | Christoph Berg | 2024-02-23 15:39:47 | Re: Printing backtrace of postgres processes |