| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Relation bulk write facility |
| Date: | 2024-02-23 16:06:01 |
| Message-ID: | 820444.1708704361@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> Thanks, the error message was clear enough:
>> bulk_write.c:78:3: error: redefinition of typedef 'BulkWriteState' is a C11 feature [-Werror,-Wtypedef-redefinition]
>> } BulkWriteState;
> Fixed now, but I'm a bit surprised other buildfarm members nor cirrus CI
> caught that. I also tried to reproduce it locally by adding
> -Wtypedef-redefinition, but my version of clang didn't produce any
> warnings. Are there any extra compiler options on those animals or
> something?
They use Apple's standard compiler (clang 15 or so), but
'CC' => 'ccache clang -std=gnu99',
so maybe the -std has something to do with it. I installed that
(or -std=gnu90 as appropriate to branch) on most of my build
setups back when we started the C99 push.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-02-23 16:15:41 | Re: SQL Property Graph Queries (SQL/PGQ) |
| Previous Message | Heikki Linnakangas | 2024-02-23 15:43:28 | Re: Relation bulk write facility |