| From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Kevin Grittner <kgrittn(at)gmail(dot)com> |
| Subject: | Re: Inadequate infrastructure for NextValueExpr |
| Date: | 2017-08-18 00:43:14 |
| Message-ID: | 87shgpn237.fsf@news-spur.riddles.org.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>>>>> "Thomas" == Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>> [...]
>> T_NamedTuplestoreScan can be produced by outfuncs.c with tagname
>> NAMEDTUPLESTORESCAN but that tagname is not recognized by readfuncs.c
>> [...]
>>
>> That revealed a defect in commit
>> 18ce3a4ab22d2984f8540ab480979c851dae5338 which I think should be
>> corrected with something like the attached, though I'm not sure if
>> it's possible to reach it.
Thomas> Adding Kevin and Andrew G. Thoughts on whether this is a
Thomas> defect that should be corrected with something like
Thomas> read-namedtuplestorescan.patch?
It's a defect that should probably be corrected for consistency, though
at present it looks like it's not actually possible to reach the code.
The patch looks good to me though I've not tested it.
Kevin, you want to take it? Or shall I deal with it?
--
Andrew (irc:RhodiumToad)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-08-18 01:13:18 | Re: Crash report for some ICU-52 (debian8) COLLATE and work_mem values |
| Previous Message | Michael Paquier | 2017-08-17 23:16:08 | Re: postgres_fdw bug in 9.6 |