From: | Andy Fan <zhihuifan1213(at)163(dot)com> |
---|---|
To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
Cc: | Japin Li <japinli(at)hotmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: New function normal_rand_array function to contrib/tablefunc. |
Date: | 2024-11-04 00:51:41 |
Message-ID: | 87ses7rfc2.fsf@163.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> On Wed, 16 Oct 2024 at 08:43, Andy Fan <zhihuifan1213(at)163(dot)com> wrote:
>>
>> Thanks for the detailed feedback! Here is the rebased version.
>>
>
> I took another look at this and I think it's in reasonable shape.
>
> I'm attaching an update, rebasing it on top of 9be4e5d293.
Thank you Dean.
> Also it was missing a required update to the meson.build file --
> that's the immediate cause of the other cfbot failures.
OK, great to know this one, I should have paid more attention to cfbot.
> The rest is just cosmetic tidying up, fixing indentation, tweaking
> comments, and the like. I also hacked on the docs a bit -- the
> synopsis only listed one of the new function signatures for some
> reason. After fixing that, I think it's sufficient to just list one
> usage example.
That looks better now, more concise and expressive sentences.
--
Best Regards
Andy Fan
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2024-11-04 02:12:48 | Re: Pgoutput not capturing the generated columns |
Previous Message | Tom Lane | 2024-11-03 22:19:09 | Re: What is a typical precision of gettimeofday()? |