| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | Andy Fan <zhihuifan1213(at)163(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: New function normal_rand_array function to contrib/tablefunc. |
| Date: | 2024-11-01 09:33:40 |
| Message-ID: | CAEZATCVnsyJNG1FqyCKPkVmx0V6PO2Xz5KTwRR1EUcsTnBb=yQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 16 Oct 2024 at 08:43, Andy Fan <zhihuifan1213(at)163(dot)com> wrote:
>
> Thanks for the detailed feedback! Here is the rebased version.
>
I took another look at this and I think it's in reasonable shape.
I'm attaching an update, rebasing it on top of 9be4e5d293.
Also it was missing a required update to the meson.build file --
that's the immediate cause of the other cfbot failures.
The rest is just cosmetic tidying up, fixing indentation, tweaking
comments, and the like. I also hacked on the docs a bit -- the
synopsis only listed one of the new function signatures for some
reason. After fixing that, I think it's sufficient to just list one
usage example.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-tablefunc-Add-rand_array-functions.patch | text/x-patch | 17.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2024-11-01 10:00:00 | Re: Improving tracking/processing of buildfarm test failures |
| Previous Message | Tatsuo Ishii | 2024-11-01 09:27:07 | Proposal to remove message length constant from F/B protocol document |