Re: fix recent WITH OIDS bug

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix recent WITH OIDS bug
Date: 2004-01-23 00:12:28
Message-ID: 87r7xrh6ab.fsf@mailbox.samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> You could possibly put it next to the existing function
> interpretInhOption(), which does essentially the same kind of thing
> and for the same reason. However, I can't argue that that
> function's placement in parse_clause.c has any real strong
> motivation either...

Yeah, I had considered that, but hesitated for the same reason you
cite. Is it worth creating a parse_util.c, perhaps? makeObjectName()
and CheckSelectForUpdate() from analyze.c might be worth moving there
as well...

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-01-23 00:48:13 Re: fix recent WITH OIDS bug
Previous Message Tom Lane 2004-01-22 21:13:50 Re: fix recent WITH OIDS bug