Re: fix recent WITH OIDS bug

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix recent WITH OIDS bug
Date: 2004-01-22 21:13:50
Message-ID: 15162.1074806030@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> The only question I have is whether analyze.c (and therefore
> analyze.h) is the right place to put the new utility function
> interpretOidsOption() -- can anyone suggest a better location?

You could possibly put it next to the existing function
interpretInhOption(), which does essentially the same kind of thing
and for the same reason. However, I can't argue that that function's
placement in parse_clause.c has any real strong motivation either...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2004-01-23 00:12:28 Re: fix recent WITH OIDS bug
Previous Message Neil Conway 2004-01-22 20:48:14 fix recent WITH OIDS bug