| From: | ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker ) |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| Date: | 2020-01-05 13:35:03 |
| Message-ID: | 87k16610xk.fsf@wibble.ilmari.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Cool, I'll go commit a fix along those lines. Thanks for tracing
> this down!
Here's one final style cleanup for the TAP test.
- use like() for the banner test
- pass the regexes around as qr// objects, so they can be
syntax-highlighted properly, and don't need regex
metacharacter-escaping backslashes doubled.
- include the regex that didn't match in the diagnostic
- ilmari
--
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
the consequences of." -- Skud's Meta-Law
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2020-01-05 13:39:11 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| Previous Message | Tatsuo Ishii | 2020-01-05 10:59:20 | pgsql: Docs: use more standard terminology "round-to-nearest-even" inst |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari Mannsåker | 2020-01-05 13:39:11 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| Previous Message | Vik Fearing | 2020-01-05 12:50:36 | Re: WIP: System Versioned Temporal Table |