| From: | ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker ) |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| Date: | 2020-01-05 13:39:11 |
| Message-ID: | 87h81a10qo.fsf@wibble.ilmari.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>
>> Cool, I'll go commit a fix along those lines. Thanks for tracing
>> this down!
>
> Here's one final style cleanup for the TAP test.
>
> - use like() for the banner test
> - pass the regexes around as qr// objects, so they can be
> syntax-highlighted properly, and don't need regex
> metacharacter-escaping backslashes doubled.
> - include the regex that didn't match in the diagnostic
This time with the actual attachment...
- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-qr-for-passed-in-regexes-in-tab-completion-TAP-t.patch | text/x-diff | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-01-05 16:35:52 | pgsql: Minor style improvements for tab-completion test. |
| Previous Message | Dagfinn Ilmari Mannsåker | 2020-01-05 13:35:03 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2020-01-05 13:39:45 | Re: parallel vacuum options/syntax |
| Previous Message | Dagfinn Ilmari Mannsåker | 2020-01-05 13:35:03 | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |