From: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org, Atri Sharma <atri(dot)jiit(at)gmail(dot)com> |
Subject: | Re: Aggregate function API versus grouping sets |
Date: | 2014-07-02 19:44:55 |
Message-ID: | 87fvijh7hv.fsf@news-spur.riddles.org.uk |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
Tom> Another approach would be to remove AggGetPerAggEContext as such
Tom> from the API altogether, and instead offer an interface that
Tom> says "register an aggregate cleanup callback", leaving it to the
Tom> agg/window core code to figure out which context to hang that
Tom> on. I had thought that exposing this econtext and the
Tom> per-input-tuple one would provide useful generality, but maybe
Tom> we should rethink that.
>> Works for me.
Tom> If we're going to do that, I think it needs to be in 9.4. Are
Tom> you going to work up a patch?
Do we want a decision on the fn_extra matter first, or shall I do one
patch for the econtext, and a following one for fn_extra?
--
Andrew (irc:RhodiumToad)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-07-02 19:45:12 | Re: log_error_verbosity and unexpected errors |
Previous Message | Fujii Masao | 2014-07-02 19:43:18 | Re: Audit of logout |