| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Atri Sharma <atri(dot)jiit(at)gmail(dot)com> |
| Subject: | Re: Aggregate function API versus grouping sets |
| Date: | 2014-07-02 18:47:04 |
| Message-ID: | 18963.1404326824@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> writes:
> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Tom> Another approach would be to remove AggGetPerAggEContext as such
> Tom> from the API altogether, and instead offer an interface that
> Tom> says "register an aggregate cleanup callback", leaving it to the
> Tom> agg/window core code to figure out which context to hang that
> Tom> on. I had thought that exposing this econtext and the
> Tom> per-input-tuple one would provide useful generality, but maybe
> Tom> we should rethink that.
> Works for me.
If we're going to do that, I think it needs to be in 9.4. Are you
going to work up a patch?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2014-07-02 18:48:53 | Re: alter user set local_preload_libraries. |
| Previous Message | Greg Stark | 2014-07-02 18:45:29 | log_error_verbosity and unexpected errors |