Re: Adding a TAP test checking data consistency on standby with minRecoveryPoint

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding a TAP test checking data consistency on standby with minRecoveryPoint
Date: 2018-11-08 06:00:29
Message-ID: 87efbwyurq.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Michael" == Michael Paquier <michael(at)paquier(dot)xyz> writes:

>> How? It's OK (and normal) for in-core pages to have newer LSNs than
>> minRecoveryPoint, it's only on-disk pages that must not be more
>> recent than that. And pageinspect will show the in-core page...

Michael> If the standby is stopped cleanly once, what's in shared
Michael> buffers gets flushed to disk by the checkpointer once at
Michael> shutdown, forcing minRecoveryPoint to be updated by the
Michael> checkpointer, and that update was not happening beforethe fix.
Michael> And once the standby is started again, what's on disk gets
Michael> reloaded, showing the inconsistency.

Ah, I missed that you were shutting down.

I think it would be nice to have a test that didn't rely on that, too.

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-11-08 06:11:35 Re: move PartitionBoundInfo creation code
Previous Message David Rowley 2018-11-08 05:59:19 Re: Removing unneeded self joins