| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: move PartitionBoundInfo creation code |
| Date: | 2018-11-08 06:11:35 |
| Message-ID: | 10bbd618-cbe3-6e56-1195-794a0a7cfcd1@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/11/08 12:59, Amit Langote wrote:
> It might be okay to split the big switch in partition_bounds_create() into
> different functions for different partitioning methods for clarity as you
> say, but let's avoid creating new files for range, list, and hash.
>
> I will post an updated patch with that break down.
And here is the new version. The break down into smaller local functions
for different partitioning methods is in patch 0002.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Code-re-arrangement-in-RelationBuildPartitionDesc.patch | text/plain | 28.9 KB |
| v3-0002-Move-out-the-PartitionBoundInfo-creation-code-int.patch | text/plain | 31.1 KB |
| v3-0003-Move-certain-code-to-partbounds.c.patch | text/plain | 42.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-08 07:00:26 | Re: Adding a TAP test checking data consistency on standby with minRecoveryPoint |
| Previous Message | Andrew Gierth | 2018-11-08 06:00:29 | Re: Adding a TAP test checking data consistency on standby with minRecoveryPoint |