| From: | Gregory Stark <stark(at)enterprisedb(dot)com> |
|---|---|
| To: | PostgreSQL-development Hackers <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Eliminate more detoast copies for packed varlenas |
| Date: | 2007-09-21 16:47:14 |
| Message-ID: | 876424ufsd.fsf@oxford.xeocode.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Ok, this removes what should be most if not all of the call sites where we're
detoasting text or byteas. In particular it gets all the regexp/like functions
and all the trim/pad functions. It also gets hashtext and hash_any.
$ zcat packed-varlena-efficiency_v0.patch.gz | diffstat
backend/access/hash/hashfunc.c | 12 !!
backend/utils/adt/like.c | 80 !!!!!!!!!!!!!!!!!!!
backend/utils/adt/oracle_compat.c | 157 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
backend/utils/adt/regexp.c | 119 !!!!!!!!!!!!!!!!!!!!!!!!!!!!
include/fmgr.h | 1
5 files changed, 5 insertions(+), 364 modifications(!)
| Attachment | Content-Type | Size |
|---|---|---|
| packed-varlena-efficiency_v0.patch.gz | application/octet-stream | 6.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-09-21 17:02:10 | Re: HOT is applied |
| Previous Message | Heikki Linnakangas | 2007-09-21 16:45:19 | Re: HOT is applied |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Smet | 2007-09-21 17:12:05 | Re: like/ilike improvements |
| Previous Message | Tom Lane | 2007-09-21 16:32:50 | Re: Minor comment fixes |