Re: like/ilike improvements

From: "Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com>
To: "Gregory Stark" <stark(at)enterprisedb(dot)com>
Cc: "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: like/ilike improvements
Date: 2007-09-21 17:12:05
Message-ID: 1d4e0c10709211012i746fe8acieae4d3d81fea40d2@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Gregory,

On 9/21/07, Gregory Stark <stark(at)enterprisedb(dot)com> wrote:
> Hm, it does seem I missed like.c when I converted all the text operators to
> avoid detoasting packed varlenas. I'll send a patch in a few minutes to do
> that. I'm surprised it would have such a large effect though.

The patch doesn't seem to apply cleanly on head (I have a problem with
oracle_compat.c). I tested it though with latin1 encoding.

The LIKE case is better:
cityvox_latin1=# SELECT e.numeve FROM evenement e WHERE e.libgeseve
LIKE '%hocus pocus%';
numeve
--------
(0 rows)

Time: 98.995 ms

-> it seems to be as fast as 8.2 was, now.

The ILIKE case seems to go into an infinite loop: postmaster takes
100% of CPU and the query never finishes.

--
Guillaume

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2007-09-21 17:13:58 Re: HOT is applied
Previous Message Merlin Moncure 2007-09-21 17:06:29 Re: HOT is applied

Browse pgsql-patches by date

  From Date Subject
Next Message Gregory Stark 2007-09-21 17:41:08 Re: like/ilike improvements
Previous Message Gregory Stark 2007-09-21 16:47:14 Eliminate more detoast copies for packed varlenas